This repository was archived by the owner on Feb 27, 2018. It is now read-only.
Test for cfg dir existance#73
Merged
SvenDowideit merged 2 commits intoMar 25, 2014
Merged
Conversation
…rd, so I rewrote the cfg dir code to keep trying until it finds an existant dir
…2docker subdir of it.
Contributor
Author
|
this is mildly urgent, as I can't release the windows 0.1-alpha installer without it. |
Contributor
Author
Contributor
|
LGTM |
2 similar comments
Contributor
|
LGTM |
Contributor
|
LGTM |
SvenDowideit
added a commit
that referenced
this pull request
Mar 25, 2014
Test for cfg dir existance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When testing on win8.1 and win7 sp1, I found that the error is different, and tbh, it looks to me like we intended to only choose a dir if it exists - so I've added the existance test
also - if we're falling back to a last hope (
cwd()) then use that dir, don't 'hope' that there is a .boot2docker dir in it.